spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <>
Subject [GitHub] spark pull request: [SPARK-8776] Increase the default MaxPermSize
Date Fri, 03 Jul 2015 02:50:11 GMT
Github user yhuai commented on a diff in the pull request:
    --- Diff: launcher/src/test/java/org/apache/spark/launcher/
    @@ -194,7 +194,7 @@ private void testCmdBuilder(boolean isDriver) throws Exception {
             if (isDriver) {
               assertEquals("-XX:MaxPermSize=256m", arg);
             } else {
    -          assertEquals("-XX:MaxPermSize=128m", arg);
    +          assertEquals("-XX:MaxPermSize=256m", arg);
    --- End diff --
    @andrewor14 What does `isDriver` do at here?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message