spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8581][SPARK-8584] Simplify checkpointin...
Date Thu, 02 Jul 2015 01:06:49 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6968#discussion_r33740116
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -194,7 +194,7 @@ abstract class RDD[T: ClassTag](
       @transient private var partitions_ : Array[Partition] = null
     
       /** An Option holding our checkpoint RDD, if we are checkpointed */
    -  private def checkpointRDD: Option[RDD[T]] = checkpointData.flatMap(_.checkpointRDD)
    +  private def checkpointRDD: Option[CheckpointRDD[T]] = checkpointData.flatMap(_.checkpointRDD)
    --- End diff --
    
    I disagree. It's bad practice to have super general types everywhere. If we want different
kinds of `CheckpointRDD`s we should have a common `CheckpointRDD` abstract class and plug
in arbitrary implementations.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message