spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4449][Core]Specify port range in spark
Date Thu, 02 Jul 2015 00:42:50 GMT
Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/5722#issuecomment-117862091
  
    Code-wise I think this is ok; but I raised the same concern in a previous comment (https://github.com/apache/spark/pull/5722#issuecomment-102134658).
Basically, having all ranges be implicit (start port + a shared "max range size") seems to
be the less problematic approach (you still may run into issues, but at least at that point
it's not a configuration issue).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message