Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: markhamstra <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-6361-spark@git.apache.org>
In-Reply-To: <git-pr-6361-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-7708] [Core] [WIP] Fixes for Kryo
 closu...
Content-Type: text/plain
Message-Id: <20150601162323.9E687E054F@git1-us-west.apache.org>
Date: Mon,  1 Jun 2015 16:23:23 +0000 (UTC)

Github user markhamstra commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6361#discussion_r31442435
  
    --- Diff: core/src/main/scala/org/apache/spark/util/SerializableBuffer.scala ---
    @@ -21,12 +21,16 @@ import java.io.{EOFException, IOException, ObjectInputStream, ObjectOutputStream
     import java.nio.ByteBuffer
     import java.nio.channels.Channels
     
    +import com.esotericsoftware.kryo.{Kryo, KryoSerializable}
    +import com.esotericsoftware.kryo.io.{Input, Output}
    +
     /**
      * A wrapper around a java.nio.ByteBuffer that is serializable through Java serialization, to make
      * it easier to pass ByteBuffers in case class messages.
      */
     private[spark]
    -class SerializableBuffer(@transient var buffer: ByteBuffer) extends Serializable {
    +class SerializableBuffer(@transient var buffer: ByteBuffer)
    +  extends Serializable with KryoSerializable {
    --- End diff --
    
    `spark.kryo.registrationRequired` -- and it is important to get this right, since registered vs. unregistered can make a large difference in the size of users' serialized classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org