spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8126] [BUILD] Use custom temp directory...
Date Fri, 05 Jun 2015 18:48:11 GMT
GitHub user vanzin opened a pull request:

    https://github.com/apache/spark/pull/6674

    [SPARK-8126] [BUILD] Use custom temp directory during build.

    Even with all the efforts to cleanup the temp directories created by
    unit tests, Spark leaves a lot of garbage in /tmp after a test run.
    This change overrides java.io.tmpdir to place those files under the
    build directory instead.
    
    After an sbt full unit test run, I was left with > 400 MB of temp
    files. Since they're now under the build dir, it's much easier to
    clean them up.
    
    Also make a slight change to a unit test to make it not pollute the
    source directory with test data.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vanzin/spark SPARK-8126

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/6674.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6674
    
----
commit 643e91660524aa920cf0107c5b49b547e2c53344
Author: Marcelo Vanzin <vanzin@cloudera.com>
Date:   2015-06-05T12:11:38Z

    [MINOR] [BUILD] Use custom temp directory during build.
    
    Even with all the efforts to cleanup the temp directories created by
    unit tests, Spark leaves a lot of garbage in /tmp after a test run.
    This change overrides java.io.tmpdir to place those files under the
    build directory instead.
    
    After an sbt full unit test run, I was left with > 400 MB of temp
    files. Since they're now under the build dir, it's much easier to
    clean them up.
    
    Also make a slight change to a unit test to make it not pollute the
    source directory with test data.
    
    Author: Marcelo Vanzin <vanzin@cloudera.com>
    
    Closes #6653 from vanzin/unit-test-tmp and squashes the following commits:
    
    31e2dd5 [Marcelo Vanzin] Fix tests that depend on each other.
    aa92944 [Marcelo Vanzin] [minor] [build] Use custom temp directory during build.

commit 0f8ad4174f01773caf276bbd3b7ee170e24ec0a8
Author: Marcelo Vanzin <vanzin@cloudera.com>
Date:   2015-06-05T18:43:54Z

    Make sure tmp dir exists when tests run.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message