spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From darabos <...@git.apache.org>
Subject [GitHub] spark pull request: Fix maxTaskFailures comment
Date Wed, 03 Jun 2015 21:16:56 GMT
GitHub user darabos opened a pull request:

    https://github.com/apache/spark/pull/6621

    Fix maxTaskFailures comment

    If maxTaskFailures is 1, the task set is aborted after 1 task failure. Other documentation
and the code supports this reading, I think it's just this comment that was off. It's easy
to make this mistake — can you please double-check if I'm correct? Thanks!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/darabos/spark patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/6621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6621
    
----
commit dfebdecf5264e947ca4ca7bac6eca6a7bfbb8a02
Author: Daniel Darabos <darabos.daniel@gmail.com>
Date:   2015-06-03T21:15:17Z

    Fix comment.
    
    If maxTaskFailures is 1, the task set is aborted after 1 task failure.
    Other documentation and the code supports this reading, I think it's just this comment
that was off.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message