spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8119] [WIP] HeartbeatReceiver should re...
Date Tue, 30 Jun 2015 21:16:08 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7107#discussion_r33624670
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
    @@ -394,6 +394,27 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl,
val rpcEnv: Rp
       }
     
       /**
    +   * Request that the cluster manager kill the specified executor without adjusting the
    +   * application resource requirements.
    +   *
    +   * The effect is that a new executor will be launched in place of the one killed by
    +   * this request. This assumes the cluster manager will automatically and eventually
    +   * fulfill all missing application resource requests.
    +   *
    +   * Return whether the request is received.
    +   */
    +  def killAndReplaceExecutor(executorId: String): Boolean = synchronized {
    --- End diff --
    
    I was planning to do that but it technically changes public API. The methods in `ExecutorAllocationClient`
are actually public because `SparkContext` extends it, so we actually can't change the signature
there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message