spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8579] [SQL] support arbitrary object in...
Date Mon, 29 Jun 2015 21:40:58 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6959#discussion_r33517056
  
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
    @@ -44,7 +36,20 @@
      * primitive types, such as long, double, or int, we store the value directly in the
word. For
      * fields with non-primitive or variable-length values, we store a relative offset (w.r.t.
the
      * base address of the row) that points to the beginning of the variable-length field,
and length
    - * (they are combined into a long).
    + * (they are combined into a long). For other objects, they are stored in a pool, the
indexes of
    + * them are hold in the the word.
    + *
    + * In order to support fast hashing and equality checks for UnsafeRows that contain objects
    + * when used as grouping key in BytesToBytesMap, we put the objects in an UniqueObjectPool
to make
    + * sure all the keyhave the same index for same object, then we can hash/compare the
objects by
    --- End diff --
    
    Typo: `keyhave`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message