spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Date Mon, 29 Jun 2015 17:56:16 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7088#discussion_r33491939
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
    @@ -570,6 +570,35 @@ private[ui] class StagePage(parent: StagesTab) extends WebUIPage("stage")
{
     
             val index = taskInfo.index
             val attempt = taskInfo.attempt
    +
    +        val svgTag =
    +          if (totalExecutionTime == 0) {
    +            """<svg class="task-assignment-timeline-duration-bar"></svg>"""
    +          }
    +          else {
    --- End diff --
    
    this should go on the previous line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message