spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1537 [WiP] Application Timeline Server i...
Date Fri, 26 Jun 2015 20:37:03 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5423#discussion_r33393505
  
    --- Diff: docs/monitoring.md ---
    @@ -74,8 +74,8 @@ follows:
       <tr>
         <td>spark.history.provider</td>
         <td>org.apache.spark.deploy.history.FsHistoryProvider</td>
    -    <td>Name of the class implementing the application history backend. Currently
there is only
    -    one implementation, provided by Spark, which looks for application logs stored in
the
    +    <td>Name of the class implementing the application history backend. The default
implementation,
    +     the FsHistoryProvider, which looks for application logs stored in the
    --- End diff --
    
    Grammar sounds weird; perhaps "The default implementation is FsHistoryProvider, which..."?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message