spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From harishreedharan <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-8562: Log the lost of an executor only i...
Date Thu, 25 Jun 2015 18:35:52 GMT
Github user harishreedharan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6952#discussion_r33289206
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
    @@ -442,15 +442,17 @@ private[spark] class TaskSchedulerImpl(
         synchronized {
           if (activeExecutorIds.contains(executorId)) {
             val hostPort = executorIdToHost(executorId)
    -        logError("Lost executor %s on %s: %s".format(executorId, hostPort, reason))
    +        lazy val msg = s"Lost executor $executorId on $hostPort: $reason"
    +        if (!sc.isStopped) logError(msg)
    --- End diff --
    
    This is passed by name anyway, so it is evaluated when it is required.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message