spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...
Date Thu, 25 Jun 2015 13:52:57 GMT
Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7014#discussion_r33256565
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -1155,7 +1156,8 @@ class DAGScheduler(
           case commitDenied: TaskCommitDenied =>
             // Do nothing here, left up to the TaskScheduler to decide how to handle denied
commits
     
    -      case ExceptionFailure(className, description, stackTrace, fullStackTrace, metrics)
=>
    +      case ExceptionFailure(className, description, stackTrace, fullStackTrace, metrics,
    +                            exception) =>
    --- End diff --
    
    nit: also not something you introduced, but while you're touching this, it can be cleaned
up.  If you're not using any of those fields, we can just check the class in the case statement
 `case _: ExceptionFailure =>`.  or since there are so many uses of underscore in scala
and they can be kinda confusing, you can bind the whole thing to a variable (even though we'll
never look at it): `case ef: ExceptionFailure =>`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message