spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenghao-intel <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8186] [SPARK-8187] [SQL] datetime funct...
Date Wed, 24 Jun 2015 05:35:08 GMT
Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6782#discussion_r33118435
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -946,6 +947,38 @@ object functions {
       def cosh(columnName: String): Column = cosh(Column(columnName))
     
       /**
    +   * Adds a number of days to startDate, given values for startDate and days
    +   *
    +   * @group datetime_funcs
    +   * @since 1.5.0
    +   */
    +  def date_add(startDate: Column, days: Column): Column = DateAdd(startDate.expr, days.expr)
    +
    +  /**
    +   * Adds a number of days to startDate, given column names for startDate and days
    +   *
    +   * @group datetime_funcs
    +   * @since 1.5.0
    +   */
    +  def date_add(startDate: String, days: String): Column = date_add(Column(startDate),
Column(days))
    --- End diff --
    
    I think we probably need to think about what we need to provide for DF api. Otherwise
the similar will happens again. E.g. Should we also provide the version like:
    ```
    def date_add(startDate: Date, days: String): Column
    def date_add(startDate: Timestamp, days: String): Column
    ...
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message