spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8583] [BUILD] Refactor python/run-tests...
Date Wed, 24 Jun 2015 01:37:16 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6967#discussion_r33110894
  
    --- Diff: python/run-tests ---
    @@ -18,165 +18,9 @@
     #
     
     
    -# Figure out where the Spark framework is installed
    -FWDIR="$(cd "`dirname "$0"`"; cd ../; pwd)"
    +FWDIR="$(cd "`dirname $0`"/..; pwd)"
    +cd "$FWDIR"
     
    -. "$FWDIR"/bin/load-spark-env.sh
    +exec python -u ./python/run-tests.py
     
    -# CD into the python directory to find things on the right path
    -cd "$FWDIR/python"
    -
    -FAILED=0
    -LOG_FILE=unit-tests.log
    -START=$(date +"%s")
    -
    -rm -f $LOG_FILE
    -
    -# Remove the metastore and warehouse directory created by the HiveContext tests in Spark
SQL
    -rm -rf metastore warehouse
    --- End diff --
    
    @ahirreddy, I think that you originally added these lines.  Do we still need them?  AFAIK
the pull request builder's `git clean -fdx` should take care of this for us, but was there
another reason why we need this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message