spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6980] [CORE] Akka timeout exceptions in...
Date Wed, 24 Jun 2015 01:25:06 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6205#discussion_r33110433
  
    --- Diff: core/src/test/scala/org/apache/spark/rpc/akka/AkkaRpcEnvSuite.scala ---
    @@ -47,4 +57,71 @@ class AkkaRpcEnvSuite extends RpcEnvSuite {
         }
       }
     
    +  test("timeout on ask Future with RpcTimeout") {
    +
    +    class EchoActor(sleepDuration: Long) extends Actor {
    --- End diff --
    
    Is it possible to write this test using the new Rpc API? Then we don't need to rewrite
this test when removing Akka.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message