spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yijieshen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8279][SQL][WIP]Add math function round
Date Tue, 23 Jun 2015 15:23:35 GMT
Github user yijieshen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6938#discussion_r33053426
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
    @@ -312,3 +315,90 @@ case class Logarithm(left: Expression, right: Expression)
         """
       }
     }
    +
    +case class Round(child: Expression, scale: Expression) extends Expression {
    +
    +  def this(child: Expression) = {
    +    this(child, Literal(0))
    +  }
    +
    +  def children: Seq[Expression] = Seq(child, scale)
    +
    +  def nullable: Boolean = true
    --- End diff --
    
    probably more than that, Hive support `String` ,`Double.NaN`, `Double.Infinity` as input,
all of these  would result in null result.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message