spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From XuTingjun <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8391] catch the Throwable and report er...
Date Tue, 23 Jun 2015 02:49:08 GMT
Github user XuTingjun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6893#discussion_r33005372
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala ---
    @@ -164,12 +164,20 @@ private[ui] object RDDOperationGraph extends Logging {
        *
        * For the complete DOT specification, see http://www.graphviz.org/Documentation/dotguide.pdf.
        */
    -  def makeDotFile(graph: RDDOperationGraph): String = {
    +  def makeDotFile(graph: RDDOperationGraph, stageId: String): String = {
         val dotFile = new StringBuilder
         dotFile.append("digraph G {\n")
    -    dotFile.append(makeDotSubgraph(graph.rootCluster, indent = "  "))
    -    graph.edges.foreach { edge => dotFile.append(s"""  ${edge.fromId}->${edge.toId};\n""")
}
    -    dotFile.append("}")
    +    try {
    +      dotFile.append(makeDotSubgraph(graph.rootCluster, indent = "  "))
    +      graph.edges.foreach { edge => dotFile.append(s"""  ${edge.fromId}->${edge.toId};\n""")
}
    +      dotFile.append("}")
    +    } catch {
    +      case t: Throwable =>
    --- End diff --
    
    @andrewor14 , ```NonFatal(e)``` will not match ```OutOfMemoryError```, but this ERROR
will happen, what should I do? Should I have an other case of  ```case e: OutOfMemoryError```?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message