spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7026] [SQL] fix left semi join with equ...
Date Mon, 22 Jun 2015 22:56:52 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5643#discussion_r32993681
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ---
    @@ -382,6 +382,18 @@ class SQLQuerySuite extends QueryTest with BeforeAndAfterAll with
SQLTestUtils {
         )
       }
     
    +  test("left semi greater than predicate and equal operator") {
    +    checkAnswer(
    +      sql("SELECT * FROM testData2 x LEFT SEMI JOIN testData2 y ON x.b = y.b and x.a
>= y.a + 2"),
    +      Seq(Row(3, 1), Row(3, 2))
    +    )
    +
    +    checkAnswer(
    +      sql("SELECT * FROM testData2 x LEFT SEMI JOIN testData2 y ON x.b = y.a and x.a
>= y.b + 1"),
    +      Seq(Row(2, 1), Row(2, 2), Row(3, 1), Row(3, 2))
    +    )
    +  }
    --- End diff --
    
    It would be great to also add some tests using the new `SparkPlanTest` infrastructure.
 In particular it seems like @Sephiroth-Lin found a bug that indicates test coverage is insufficient.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message