spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nishkamravi2 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7988][STREAMING] Round-robin scheduling...
Date Thu, 18 Jun 2015 08:24:11 GMT
Github user nishkamravi2 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6607#discussion_r32707963
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
---
    @@ -308,12 +336,25 @@ class ReceiverTracker(ssc: StreamingContext, skipReceiverLaunch:
Boolean = false
             supervisor.start()
             supervisor.awaitTermination()
           }
    +
           // Run the dummy Spark job to ensure that all slaves have registered.
           // This avoids all the receivers to be scheduled on the same node.
           if (!ssc.sparkContext.isLocal) {
             ssc.sparkContext.makeRDD(1 to 50, 50).map(x => (x, 1)).reduceByKey(_ + _,
20).collect()
           }
     
    +      // Get the list of executors and schedule receivers
    +      val executors = getExecutors(ssc)
    +      val locations = scheduleReceivers(receivers, executors)
    +      val tempRDD =
    +        if (locations(0) != null) {
    --- End diff --
    
    location(0) check is all-encompassing (no assumptions made about when it may be true).
We can add a comment next to it to clarify that it can be null for local.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message