spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8301][SQL] Improve UTF8String substring...
Date Thu, 18 Jun 2015 00:29:21 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6804#discussion_r32690229
  
    --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -125,30 +129,37 @@ public UTF8String substring(final int start, final int until) {
       }
     
       public boolean contains(final UTF8String substring) {
    +    if (substring == null) return false;
         final byte[] b = substring.getBytes();
         if (b.length == 0) {
           return true;
         }
     
         for (int i = 0; i <= bytes.length - b.length; i++) {
    -      // TODO: Avoid copying.
    -      if (bytes[i] == b[0] && Arrays.equals(Arrays.copyOfRange(bytes, i, i +
b.length), b)) {
    +      if (bytes[i] == b[0] && startsWith(b, i)) {
             return true;
           }
         }
         return false;
       }
     
    +  private boolean startsWith(final byte[] prefix, int offset) {
    --- End diff --
    
    how about remaining it offsetInBytes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message