spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [Streaming][Kafka][SPARK-8389] Example of gett...
Date Wed, 17 Jun 2015 07:29:28 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6846#discussion_r32601142
  
    --- Diff: external/kafka/src/test/java/org/apache/spark/streaming/kafka/JavaDirectKafkaStreamSuite.java
---
    @@ -89,6 +90,16 @@ public void testKafkaStream() throws InterruptedException {
             StringDecoder.class,
             kafkaParams,
             topicToSet(topic1)
    +    ).transformToPair(
    +        // Make sure you can get offset ranges from the rdd
    +        new Function<JavaPairRDD<String, String>, JavaPairRDD<String, String>>()
{
    +          @Override
    +          public JavaPairRDD<String, String> call(JavaPairRDD<String, String>
rdd) throws Exception {
    +            OffsetRange[] offsets = ((HasOffsetRanges)rdd.rdd()).offsetRanges();
    --- End diff --
    
    Nit, not worth fixing unless you make another change: space after the cast.
    Was the intent of the JIRA to add something to an example? this is an addition a test
which is even better, but I also read that it's users who want to know about this too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message