spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenghao-intel <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8301][SQL] Improve UTF8String substring...
Date Wed, 17 Jun 2015 05:25:25 GMT
Github user chenghao-intel commented on the pull request:

    https://github.com/apache/spark/pull/6804#issuecomment-112654759
  
    @tarekauel Glad to see the big improvement for the performance gain! I have some comments
on the API change, e.g. the `null` value checking, comparison with `null`, probably we'd better
not change its original behavior for `UTF8String`, seems behavior as `java.lang.String` does
will be reasonable to me, what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message