spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adrian-wang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...
Date Wed, 17 Jun 2015 02:36:02 GMT
Github user adrian-wang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6762#discussion_r32591224
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -1339,19 +1339,361 @@ object functions {
       //////////////////////////////////////////////////////////////////////////////////////////////
     
       /**
    -   * Computes the length of a given string value
    +   * Computes the length of a given string value.
        * @group string_funcs
        * @since 1.5.0
        */
       def strlen(e: Column): Column = StringLength(e.expr)
     
       /**
    -   * Computes the length of a given string column
    +   * Computes the length of a given string column.
        * @group string_funcs
        * @since 1.5.0
        */
       def strlen(columnName: String): Column = strlen(Column(columnName))
     
    +  /**
    +   * Trim the spaces from both ends for the specified string value.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def trim(e: Column): Column = StringTrim(e.expr)
    +
    +  /**
    +   * Trim the spaces from both ends for the specified column.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def trim(columnName: String): Column = trim(Column(columnName))
    +
    +  /**
    +   * Trim the spaces from left end for the specified string value.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def ltrim(e: Column): Column = StringTrimLeft(e.expr)
    +
    +  /**
    +   * Trim the spaces from left end for the specified column.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def ltrim(columnName: String): Column = ltrim(Column(columnName))
    +
    +  /**
    +   * Trim the spaces from right end for the specified string value.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def rtrim(e: Column): Column = StringTrimRight(e.expr)
    +
    +  /**
    +   * Trim the spaces from right end for the specified column.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def rtrim(columnName: String): Column = rtrim(Column(columnName))
    +
    +  /**
    +   * Format strings in printf-style.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  @scala.annotation.varargs
    +  def formatString(format: Column, arguments: Column*): Column = {
    +    StringFormat((format +: arguments).map(_.expr): _*)
    +  }
    +
    +  /**
    +   * Format strings in printf-style.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  @scala.annotation.varargs
    +  def formatString(format: String, arguments: String*): Column = {
    +    StringFormat((format +: arguments).map(Column(_).expr): _*)
    +  }
    +
    +  /**
    +   * Locate the position of the first occurrence of substr value in the given string.
    +   * Returns null if either of the arguments are null and
    +   * returns 0 if substr could not be found in str.
    +   *
    +   * Be aware the position is not zero based, but 1 based index.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def instr(substr: String, sub: String): Column = instr(Column(substr), Column(sub))
    +
    +  /**
    +   * Locate the position of the first occurrence of substr column in the given string.
    +   * Returns null if either of the arguments are null and
    +   * returns 0 if substr could not be found in str.
    +   *
    +   * Be aware the position is not zero based, but 1 based index.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def instr(substr: Column, sub: Column): Column = StringInstr(substr.expr, sub.expr)
    +
    +  /**
    +   * Locate the position of the first occurrence of substr.
    +   * Be aware the position is not zero based, but 1 based index.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def locate(substr: String, str: String): Column = {
    +    locate(Column(substr), Column(str))
    +  }
    +
    +  /**
    +   * Locate the position of the first occurrence of substr.
    +   * Be aware the position is not zero based, but 1 based index.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def locate(substr: Column, str: Column): Column = {
    +    new StringLocate(substr.expr, str.expr)
    +  }
    +
    +  /**
    +   * Locate the position of the first occurrence of substr in a given string after position
pos.
    +   * Be aware the position is not zero based, but 1 based index.
    +   * If the value that `pos` represent is null, the expression value will be 0.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def locate(substr: String, str: String, pos: String): Column = {
    +    locate(Column(substr), Column(str), Column(pos))
    +  }
    +
    +  /**
    +   * Locate the position of the first occurrence of substr in a given string after position
pos.
    +   * Be aware the position is not zero based, but 1 based index.
    +   * If the value that `pos` represent is null, the expression value will be 0.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def locate(substr: Column, str: Column, pos: Column): Column = {
    +    StringLocate(substr.expr, str.expr, pos.expr)
    +  }
    +
    +  /**
    +   * Locate the position of the first occurrence of substr in a given string after position
pos.
    +   * Be aware the position is not zero based, but 1 based index.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def locate(substr: Column, str: Column, pos: Int): Column = {
    +    StringLocate(substr.expr, str.expr, lit(pos).expr)
    +  }
    +
    +  /**
    +   * Locate the position of the first occurrence of substr in a given string after position
pos.
    +   * Be aware the position is not zero based, but 1 based index.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def locate(substr: String, str: String, pos: Int): Column = {
    +    locate(Column(substr), Column(str), lit(pos))
    +  }
    +
    +  /**
    +   * Left-padded with pad to a length of len.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def lpad(str: String, len: String, pad: String): Column = {
    +    lpad(Column(str), Column(len), Column(pad))
    +  }
    +
    +  /**
    +   * Left-padded with pad to a length of len.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def lpad(str: Column, len: Column, pad: Column): Column = {
    +    StringLPad(str.expr, len.expr, pad.expr)
    +  }
    +
    +  /**
    +   * Left-padded with pad to a length of len.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def lpad(str: String, len: Int, pad: String): Column = {
    +    lpad(Column(str), len, Column(pad))
    +  }
    +
    +  /**
    +   * Left-padded with pad to a length of len.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def lpad(str: Column, len: Int, pad: Column): Column = {
    +    StringLPad(str.expr, lit(len).expr, pad.expr)
    +  }
    +
    +  /**
    +   * Right-padded with pad to a length of len.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def rpad(str: String, len: String, pad: String): Column = {
    +    rpad(Column(str), Column(len), Column(pad))
    +  }
    +
    +  /**
    +   * Right-padded with pad to a length of len.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def rpad(str: Column, len: Column, pad: Column): Column = {
    +    StringRPad(str.expr, len.expr, pad.expr)
    +  }
    +
    +  /**
    +   * Right-padded with pad to a length of len.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def rpad(str: String, len: Int, pad: String): Column = {
    +    rpad(Column(str), len, Column(pad))
    +  }
    +
    +  /**
    +   * Right-padded with pad to a length of len.
    +   *
    +   * @group string_funcs
    +   * @since 1.5.0
    +   */
    +  def rpad(str: Column, len: Int, pad: Column): Column = {
    +    StringRPad(str.expr, lit(len).expr, pad.expr)
    +  }
    +
    +  /**
    +   * Repeat the string value n times.
    --- End diff --
    
    column


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message