spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8309] [CORE] Support for more than 12M ...
Date Mon, 15 Jun 2015 07:30:13 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6763#discussion_r32396635
  
    --- Diff: core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala ---
    @@ -278,7 +279,7 @@ object OpenHashSet {
     
       val INVALID_POS = -1
       val NONEXISTENCE_MASK = 0x80000000
    -  val POSITION_MASK = 0xEFFFFFF
    +  val POSITION_MASK = 0x7FFFFFFF
    --- End diff --
    
    @srowen I think it's very easy to miss some `F` in a hex string just like this issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message