spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dibbhatt <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8080][STREAMING] Receiver.store with It...
Date Sat, 13 Jun 2015 09:29:40 GMT
Github user dibbhatt commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6707#discussion_r32369255
  
    --- Diff: streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala
---
    @@ -62,6 +61,19 @@ class ReceivedBlockHandlerSuite
       var blockManagerMaster: BlockManagerMaster = null
       var blockManager: BlockManager = null
       var tempDirectory: File = null
    +  var storageLevel = StorageLevel.MEMORY_ONLY_SER
    --- End diff --
    
    I can even set the StorageLevel back to default value in Before block which can reset
the global variable before every test. Anyone write new test can see the before block to check
what is global state. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message