spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenghao-intel <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8221][SQL]Add pmod function
Date Fri, 12 Jun 2015 13:58:21 GMT
Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6783#discussion_r32317651
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -1205,6 +1205,70 @@ object functions {
       def pow(l: Double, rightName: String): Column = pow(l, Column(rightName))
     
       /**
    +   * Returns the positive value of l mod r.
    +   *
    +   * @group math_funcs
    +   * @since 1.5.0
    +   */
    +  def pmod(l: Column, r: Column): Column = Pmod(l.expr, r.expr)
    +
    +  /**
    +   * Returns the positive value of l mod r.
    +   *
    +   * @group math_funcs
    +   * @since 1.5.0
    +   */
    +  def pmod(l: Column, rightName: String): Column = pmod(l, Column(rightName))
    +
    +  /**
    +   * Returns the positive value of l mod r.
    +   *
    +   * @group math_funcs
    +   * @since 1.5.0
    +   */
    +  def pmod(leftName: String, r: Column): Column = pmod(Column(leftName), r)
    --- End diff --
    
    +1, let's keep minimal API added for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message