spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lianhuiwang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8302] Support heterogeneous cluster ins...
Date Fri, 12 Jun 2015 10:00:20 GMT
Github user lianhuiwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6752#discussion_r32303953
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -1183,6 +1187,29 @@ object Client extends Logging {
         YarnSparkHadoopUtil.addPathToEnvironment(env, Environment.CLASSPATH.name, path)
     
       /**
    +   * Returns the path to be sent to the NM for a local path string.
    +   *
    +   * This method uses two configuration values:
    +   *
    +   * - spark.yarn.config.localPath: a string that identifies a portion of the input path
that may
    +   *   only be valid in the local process.
    +   * - spark.yarn.config.clusterPath: a string with which to replace the local path.
This may
    +   *   contain, for example, env variable references, which will be expanded by the NMs
when
    +   *   starting containers.
    +   *
    +   * If either config is not available, the input path is returned.
    +   */
    +  def getClusterPath(conf: SparkConf, path: String): String = {
    --- End diff --
    
    i think it is better for putting getClusterPath into YarnSparkHadoopUtil object.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message