spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8234][SQL] misc function: md5
Date Fri, 12 Jun 2015 08:32:10 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6779#discussion_r32298399
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
    @@ -0,0 +1,58 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst.expressions
    +
    +import java.security.MessageDigest
    +
    +import org.apache.commons.codec.digest.DigestUtils
    +import org.apache.spark.sql.catalyst.analysis.TypeCheckResult
    +import org.apache.spark.sql.types.{BinaryType, StringType, DataType}
    +import org.apache.spark.unsafe.types.UTF8String
    +
    +/**
    + * A function that calculates an MD5 128-bit checksum for the string or binary.
    + * Defined for String and Binary types.
    + */
    +case class Md5(child: Expression) extends UnaryExpression {
    +
    +  override def dataType: DataType = StringType
    +
    +  override def checkInputDataTypes(): TypeCheckResult =
    +    if (child.dataType == StringType || child.dataType == BinaryType) {
    --- End diff --
    
    According to your implementation of `eval`, you should also allow `NullType` here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message