spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dibbhatt <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8080][STREAMING] Receiver.store with It...
Date Fri, 12 Jun 2015 08:29:03 GMT
Github user dibbhatt commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6707#discussion_r32298168
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/receiver/ReceivedBlockHandler.scala
---
    @@ -151,13 +167,21 @@ private[streaming] class WriteAheadLogBasedBlockHandler(
        */
       def storeBlock(blockId: StreamBlockId, block: ReceivedBlock): ReceivedBlockStoreResult
= {
     
    +    var numRecords = None: Option[Long]
         // Serialize the block so that it can be inserted into both
         val serializedBlock = block match {
           case ArrayBufferBlock(arrayBuffer) =>
    -        blockManager.dataSerialize(blockId, arrayBuffer.iterator)
    +        val countIterator = new CountingIterator(arrayBuffer.iterator)
    --- End diff --
    
    Ok. Will change back to as it was earlier. But if we do not go through CountingIterator
we may not know if Block is fullyConsumed or not. But we are not using isFullyConsumed presently
, so this should be fine. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message