spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...
Date Fri, 12 Jun 2015 02:06:07 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6686#discussion_r32285988
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ---
    @@ -104,6 +104,69 @@ case class StructType(fields: Array[StructField]) extends DataType
with Seq[Stru
       private lazy val nameToIndex: Map[String, Int] = fieldNames.zipWithIndex.toMap
     
       /**
    +   * Creates a new [[StructType]] by adding a new field.
    +   * {{{
    +   * val struct = (new StructType)
    +   *   .add(StructField("a", IntegerType, true))
    +   *   .add(StructField("b", LongType, false))
    +   *   .add(StructField("c", StringType, true))
    +   *}}}
    +   */
    +  def add(field: StructField): StructType = {
    +    StructType(fields :+ field)
    +  }
    +
    +  /**
    +   * Creates a new [[StructType]] by adding a new field.
    +   *
    +   * val struct = (new StructType)
    +   *   .add(StructField("a", IntegerType, true))
    +   *   .add(StructField("b", LongType, false))
    +   *   .add(StructField("c", StringType, true))
    +   */
    +  def add(name: String, dataType: DataType): StructType = {
    +    StructType(fields :+ new StructField(name, dataType, true, Metadata.empty))
    +  }
    +
    +  def add(name: String, dataType: DataType, nullable: Boolean): StructType = {
    --- End diff --
    
    and add documentation for these methods too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message