spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8286] Rewrite UTF8String in Java and mo...
Date Thu, 11 Jun 2015 07:37:39 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6738#discussion_r32196200
  
    --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -0,0 +1,206 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.unsafe.types;
    +
    +import java.io.Serializable;
    +import java.io.UnsupportedEncodingException;
    +import java.util.Arrays;
    +import javax.annotation.Nullable;
    +
    +import org.apache.spark.unsafe.PlatformDependent;
    +
    +/**
    + * A UTF-8 String for internal Spark use.
    + * <p>
    + * A String encoded in UTF-8 as an Array[Byte], which can be used for comparison,
    + * search, see http://en.wikipedia.org/wiki/UTF-8 for details.
    + * <p>
    + * Note: This is not designed for general use cases, should not be used outside SQL.
    + */
    +public final class UTF8String implements Comparable<UTF8String>, Serializable {
    +
    +  @Nullable
    +  private byte[] bytes;
    +
    +  private static int[] bytesOfCodePointInUTF8 = {2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,
    --- End diff --
    
    yup. good to be final.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message