spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From massie <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7884] Move block deserialization from B...
Date Wed, 10 Jun 2015 23:36:37 GMT
Github user massie commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6423#discussion_r32177982
  
    --- Diff: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala
---
    @@ -57,7 +58,16 @@ class ShuffleBlockFetcherIteratorSuite extends SparkFunSuite {
         transfer
       }
     
    -  private val conf = new SparkConf
    +  // Create a mock managed buffer for testing
    +  def createMockManagedBuffer(): ManagedBuffer = {
    +    val mockManagedBuffer = mock(classOf[ManagedBuffer])
    +    when(mockManagedBuffer.createInputStream()).thenAnswer(new Answer[InputStream] {
    --- End diff --
    
    Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message