spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From massie <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7884] Move block deserialization from B...
Date Wed, 10 Jun 2015 22:25:16 GMT
Github user massie commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6423#discussion_r32173458
  
    --- Diff: core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
    @@ -17,23 +17,21 @@
     
     package org.apache.spark.shuffle.hash
     
    -import scala.collection.mutable.ArrayBuffer
    -import scala.collection.mutable.HashMap
    +import java.io.InputStream
    +
    +import scala.collection.mutable.{ArrayBuffer, HashMap}
     import scala.util.{Failure, Success, Try}
     
     import org.apache.spark._
    -import org.apache.spark.serializer.Serializer
     import org.apache.spark.shuffle.FetchFailedException
     import org.apache.spark.storage.{BlockId, BlockManagerId, ShuffleBlockFetcherIterator,
ShuffleBlockId}
    -import org.apache.spark.util.CompletionIterator
     
    -private[hash] object BlockStoreShuffleFetcher extends Logging {
    -  def fetch[T](
    +private[shuffle] object BlockStoreShuffleFetcher extends Logging {
    --- End diff --
    
    Will do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message