spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8075][SQL] apply type check interface t...
Date Wed, 10 Jun 2015 02:37:32 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6723#discussion_r32084143
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalFunctions.scala
---
    @@ -28,6 +29,15 @@ case class UnscaledValue(child: Expression) extends UnaryExpression
{
       override def nullable: Boolean = child.nullable
       override def toString: String = s"UnscaledValue($child)"
     
    +  override def checkInputDataTypes(): TypeCheckResult = {
    +    if (child.dataType.isInstanceOf[DecimalType]) {
    +      TypeCheckResult.TypeCheckSuccess
    +    } else {
    +      TypeCheckResult.TypeCheckFailure(
    +        s"UnscaledValue only accept decimal type, not ${child.dataType}")
    --- End diff --
    
    This thing is only added by the optimizer so I guess it is not that big of a deal to do
this check... can you add an inline comment for this expression saying this is internal and
created only by the optimizer?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message