spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7184] [SQL] enable codegen by default
Date Tue, 09 Jun 2015 23:18:44 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6726#discussion_r32075165
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/commands.scala ---
    @@ -218,24 +218,20 @@ private[sql] case class InsertIntoHadoopFsRelation(
             val partitionProj = newProjection(codegenEnabled, partitionOutput, output)
             val dataProj = newProjection(codegenEnabled, dataOutput, output)
     
    -        if (needsConversion) {
    -          val converter = CatalystTypeConverters.createToScalaConverter(dataSchema)
    -          while (iterator.hasNext) {
    -            val row = iterator.next()
    -            val partitionPart = partitionProj(row)
    -            val dataPart = dataProj(row)
    -            val convertedDataPart = converter(dataPart).asInstanceOf[Row]
    -            writerContainer.outputWriterForRow(partitionPart).write(convertedDataPart)
    -          }
    +        val partitionSchema = StructType.fromAttributes(partitionOutput)
    +        val partConverter = CatalystTypeConverters.createToScalaConverter(partitionSchema)
    --- End diff --
    
    The Row came from Projection always have Catalyst type, so we need to convert them to
Scala type. The old code is buggy, but not covered by unit tests (non-codegen Projection does
not check types).
    
    cc @liancheng 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message