spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8080][STREAMING] Receiver.store with It...
Date Fri, 05 Jun 2015 22:50:00 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6614#discussion_r31858075
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/receiver/ReceivedBlockHandler.scala
---
    @@ -33,6 +33,7 @@ import org.apache.spark.{Logging, SparkConf, SparkException}
     /** Trait that represents the metadata related to storage of blocks */
     private[streaming] trait ReceivedBlockStoreResult {
       def blockId: StreamBlockId  // Any implementation of this trait will store a block
id
    +  def numRecords: Long        // Any implementation of this trait will store the number
of records
    --- End diff --
    
    "will have to return the number of records"
    
    Also, this should probably be an Option. See the #6659 that I merged. Please merge with
master to get those changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message