spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [WIP] [SPARK-8117] [SQL] Move codegen implemen...
Date Fri, 05 Jun 2015 02:29:15 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6660#discussion_r31783787
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
    @@ -685,13 +163,106 @@ abstract class CodeGenerator[InType <: AnyRef, OutType <:
AnyRef] extends Loggin
       }
     
       /**
    +   * Returns a function to generate equal expression in Java
    +   */
    +  def equalFunc(dataType: DataType): ((Term, Term) => Code) = dataType match {
    +    case BinaryType => { case (eval1, eval2) => s"java.util.Arrays.equals($eval1,
$eval2)" }
    +    case dt if isNativeType(dt) => { case (eval1, eval2) => s"$eval1 == $eval2"
}
    --- End diff --
    
    Yea but the definition of native type (4 lines down) is : " List of data types that have
special accessors and setters in [[Row]]." Which means in the future we might break this.
    
    I'd make it explicit with primitive type here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message