spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7699][Core] Lazy start the scheduler fo...
Date Thu, 04 Jun 2015 00:06:15 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6430#discussion_r31683487
  
    --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -261,14 +269,19 @@ private[spark] class ExecutorAllocationManager(
       private def updateAndSyncNumExecutorsTarget(now: Long): Int = synchronized {
         val maxNeeded = maxNumExecutorsNeeded
     
    -    if (maxNeeded < numExecutorsTarget) {
    +    if (initializing && (maxNeeded < numExecutorsTarget)) {
    +      // when ExecutorAllocationManager is still in initializing status,
    +      // and the max number of needed executors is less than the initial number of executors,
    +      // we just return without doing anything.
    +      0
    +    } else if (!initializing && maxNeeded < numExecutorsTarget) {
    --- End diff --
    
    This is pretty long-winded. I think we can just do
    ```
    if (initializing) {
    } else if (maxNeeded < numExecutorsTarget) {
    } ...
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message