spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7956] [SQL] Use Janino to compile SQL e...
Date Wed, 03 Jun 2015 23:58:00 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6479#discussion_r31683044
  
    --- Diff: core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala ---
    @@ -37,7 +37,6 @@ import com.google.common.hash.Hashing
      * It uses quadratic probing with a power-of-2 hash table size, which is guaranteed
      * to explore all spaces for each key (see http://en.wikipedia.org/wiki/Quadratic_probing).
      */
    -private[spark]
    --- End diff --
    
    Do we have to remove this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message