spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From massie <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7884] Allow Spark shuffle APIs to be mo...
Date Tue, 02 Jun 2015 16:08:40 GMT
Github user massie commented on the pull request:

    https://github.com/apache/spark/pull/6423#issuecomment-108002390
  
    Thanks for the tip. I'll make sure to leave the commits separate moving forward.
    
    I looked into the use of `Try` between the `BlockStoreShuffleFetcher` and `ShuffleBlockFetcherIterator`.
The `ShuffleBlockFetcherIterator` has no information about server statuses from the map output
tracker, shuffle IDs, etc. Using `Try` allows the `BlockStoreShuffleFetcher` to reformat exceptions
as a `FetchFailedException` which is the right exception to return to the scheduler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message