spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7965] [SPARK-7972] [SQL] Handle express...
Date Tue, 02 Jun 2015 04:40:32 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6524#discussion_r31492488
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -644,14 +644,24 @@ class Analyzer(
         }
     
         /**
    -     * From a Seq of [[NamedExpression]]s, extract window expressions and
    -     * other regular expressions.
    +     * From a Seq of [[NamedExpression]]s, extract expressions containing window expressions
and
    +     * other regular expressions that do not contain any window expression. For example,
for
    +     * `col1, Sum(col2 + col3) OVER (PARTITION BY col4 ORDER BY col5)`, we will extract
    +     * `col1`, `col2 + col3`, `col4`, and `col5` out and replace them appearances in
    --- End diff --
    
    ok I will merge this and fix the typo myself.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message