spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7562][SPARK-6444][SQL] Improve error re...
Date Sun, 31 May 2015 22:04:10 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6405#discussion_r31394820
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
    @@ -395,10 +362,13 @@ case class CaseWhen(branches: Seq[Expression]) extends CaseWhenLike
{
     
       override def children: Seq[Expression] = branches
     
    -  override lazy val resolved: Boolean =
    -    childrenResolved &&
    -    whenList.forall(_.dataType == BooleanType) &&
    -    valueTypesEqual
    +  override protected def checkTypesInternal(): TypeCheckResult = {
    +    if (whenList.forall(_.dataType == BooleanType)) {
    +      TypeCheckResult.success
    +    } else {
    +      TypeCheckResult.fail(s"WHEN expressions in CaseWhen should all be boolean type")
    --- End diff --
    
    Perhaps include the first one that fails and its type in the error?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message