spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7955][Core] Ensure executors with cache...
Date Sat, 30 May 2015 07:15:15 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6508#discussion_r31378610
  
    --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -443,9 +466,27 @@ private[spark] class ExecutorAllocationManager(
       private def onExecutorIdle(executorId: String): Unit = synchronized {
         if (executorIds.contains(executorId)) {
           if (!removeTimes.contains(executorId) && !executorsPendingToRemove.contains(executorId))
{
    +
    +        val hasCachedBlocks =
    +          executorsWithCachedBlocks.contains(executorId) ||
    +            executorEndpoints.get(executorId).exists(_.askWithRetry[Boolean](HasCachedBlocks))
    +
    +        if (hasCachedBlocks) executorsWithCachedBlocks += executorId
    --- End diff --
    
    actually, does it make sense to add executors to this map here? This happens when we remove
the executor, in which case we'll never ask it whether it has cached blocks any more. I think
we can actually do away with this map without changing the behavior at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message