spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SQL][minor] remove unnecessary type coercion ...
Date Sat, 30 May 2015 06:28:00 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6516#discussion_r31378410
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
    @@ -511,32 +510,6 @@ trait HiveTypeCoercion {
       }
     
       /**
    -   * Casts to/from [[BooleanType]] are transformed into comparisons since
    -   * the JVM does not consider Booleans to be numeric types.
    -   */
    -  object BooleanCasts extends Rule[LogicalPlan] {
    -    def apply(plan: LogicalPlan): LogicalPlan = plan transformAllExpressions {
    -      // Skip nodes who's children have not been resolved yet.
    -      case e if !e.childrenResolved => e
    -      // Skip if the type is boolean type already. Note that this extra cast should be
removed
    -      // by optimizer.SimplifyCasts.
    -      case Cast(e, BooleanType) if e.dataType == BooleanType => e
    --- End diff --
    
    i.e. this is basically constant folding.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message