spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7558] Demarcate tests in unit-tests.log
Date Fri, 29 May 2015 18:32:17 GMT
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/6441#issuecomment-106898242
  
    Yes, but the error message the developer gets is the same. It's a little strange from
the developer's perspective: they're just extending a class, which is totally legitimate,
and suddenly they get `This patch fails Scala style checks`.
    
    Also, it actually won't work unless we exclude certain files, because `SparkFunSuite`
does extend `FunSuite`. I just think a better place to do it would be in the PR diff.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message