spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7930][CORE][STREAMING] Fixed shutdown h...
Date Fri, 29 May 2015 15:28:58 GMT
Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/6482#issuecomment-106845812
  
    Good catch. LGTM. I agree with Patrick that a different constant for the DiskBlockManager
might be clearer (i.e. "why is the block manager using the temp dir priority?"), or at least
a comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message