spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7931][STREAMING] Do not restart receive...
Date Fri, 29 May 2015 01:18:55 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6483#discussion_r31292922
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/SocketInputDStream.scala
---
    @@ -74,13 +76,16 @@ class SocketReceiver[T: ClassTag](
           while(!isStopped && iterator.hasNext) {
             store(iterator.next)
           }
    +      if (!isStopped()) {
    +        restart("Socket data stream had no more data")
    +      }
           logInfo("Stopped receiving")
    --- End diff --
    
    It's better to put `logInfo("Stopped receiving")` to the else clause like this:
    
    ```Scala
    if (!isStopped()) {
            restart("Socket data stream had no more data")
    } else {
           logInfo("Stopped receiving")
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message