spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sryza <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7699][Core] Lazy start the scheduler fo...
Date Thu, 28 May 2015 20:39:31 GMT
Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6430#discussion_r31275291
  
    --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -262,15 +267,22 @@ private[spark] class ExecutorAllocationManager(
         val maxNeeded = maxNumExecutorsNeeded
     
         if (maxNeeded < numExecutorsTarget) {
    -      // The target number exceeds the number we actually need, so stop adding new
    -      // executors and inform the cluster manager to cancel the extra pending requests
    -      val oldNumExecutorsTarget = numExecutorsTarget
    -      numExecutorsTarget = math.max(maxNeeded, minNumExecutors)
    -      client.requestTotalExecutors(numExecutorsTarget)
    -      numExecutorsToAdd = 1
    -      logInfo(s"Lowering target number of executors to $numExecutorsTarget because "
+
    -        s"not all requests are actually needed (previously $oldNumExecutorsTarget)")
    -      numExecutorsTarget - oldNumExecutorsTarget
    +      if (!numTargetExecutorAdjustable.get) {
    +        // Keep the initial number of target executor to not ramp down until the first
job is
    --- End diff --
    
    That's not that approach that I thought we settled on.  Is there a basis for that which
I'm missing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message