spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [MINOR] change new Exception to sys.err
Date Thu, 28 May 2015 08:37:15 GMT
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/6434#issuecomment-106232448
  
    A subclass of `RuntimeException` is appropriate then. I use `IllegalArgumentException`
for something basically related to input to the method, and `IllegalStateException` as a more
general subclass of `RuntimeException`. It's quite minor, but while we're here, I'd rather
do what I think is the general best practice in Java-land.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message