spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From evacchi <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7727] Avoid inner classes in RuleExecut...
Date Thu, 28 May 2015 07:33:18 GMT
Github user evacchi commented on the pull request:

    https://github.com/apache/spark/pull/6319#issuecomment-106210025
  
    @chenghao-intel although Batch may not be supposed to be public, inner classes are still
bad when it comes to sharing code (because they are not static inner). I'd advise to make
them at least inner to a companion object; see PR #6349


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message